apoorvmittal10 commented on code in PR #19881:
URL: https://github.com/apache/kafka/pull/19881#discussion_r2123173713
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -718,7 +717,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (IOException e) {
+ } catch (Throwable e) {
log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
For `log.info("Failed to compress telemetry payload for....`, should it be
in debug mode i.e. silent exception. Or we should still log it in INFO mode so
application is aware of? What others think @AndrewJSchofield @bbejeck @chia7712
@k-raina?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
