adixitconfluent commented on PR #19872: URL: https://github.com/apache/kafka/pull/19872#issuecomment-2936051198
@ji-seung-ryu I think we should get rid of this test `testMultipleConcurrentShareFetches`. When this test was written originally, we didn't have the `DelayedShareFetchPurgatory`. We had a custom logic of limiting `replicaManager readFromLog` calls, hence we needed to verify whether the incoming new requests are waiting/getting ignored until the requests for a given share group member are in pipeline. Now, with `DelayedShareFetchPurgatory`, we get that guarantee already. Hence, it makes sense to me that we delete this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
