lianetm opened a new pull request, #19903: URL: https://github.com/apache/kafka/pull/19903
Fix to ensure protocol name comparison in integration test ignore case (group protocol from param is lower case, vs enum name upper case) The tests were not failing but the custom configs/expectation were not being applied depending on the protocol (the tests checks for "groupProtocol.equals(CLASSIC)" would never be true. Found all comparisons with equals agains the constant name and fixed them (not too many luckily). I did consider changing the protocol param that is passed to every test (that is now lowercase), but still, seems more robust to have the tests ignore case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
