Copilot commented on code in PR #19908:
URL: https://github.com/apache/kafka/pull/19908#discussion_r2128937509
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -1047,6 +1051,21 @@ private KafkaStreams(final TopologyMetadata
topologyMetadata,
rocksDBMetricsRecordingService =
maybeCreateRocksDBMetricsRecordingService(clientId, applicationConfigs);
}
+ private void throwIfUnsupportedFeatureIsUsedWithStreamsRebalanceProtocol()
{
+ if
(applicationConfigs.getString(StreamsConfig.GROUP_PROTOCOL_CONFIG).equalsIgnoreCase(GroupProtocol.STREAMS.name))
{
Review Comment:
Consider invoking GroupProtocol.STREAMS.name() (with parentheses) instead of
GroupProtocol.STREAMS.name to correctly compare the protocol string.
```suggestion
if
(applicationConfigs.getString(StreamsConfig.GROUP_PROTOCOL_CONFIG).equalsIgnoreCase(GroupProtocol.STREAMS.name()))
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
