lianetm commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2945108957
Thanks for the update! Just a nit, `throwIfGroupIdNotDefined` or similar is probably the accurate one. The validation for empty group ID happens first, at a higher level in the constructor https://github.com/apache/kafka/blob/f86659423d0e28981102e0e71d740490160df815/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java#L161 , and then we have some APIs that require group Id (so they throwIfGroupIdNotDefined) (Sorry I suggested the empty myself initially, mixing empty optional vs empty string) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
