AndrewJSchofield commented on code in PR #19907: URL: https://github.com/apache/kafka/pull/19907#discussion_r2131666553
########## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ShareGroupAssignorBenchmark.java: ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.jmh.assignor; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.api.assignor.GroupAssignment; +import org.apache.kafka.coordinator.group.api.assignor.GroupSpec; +import org.apache.kafka.coordinator.group.api.assignor.MemberAssignment; +import org.apache.kafka.coordinator.group.api.assignor.PartitionAssignor; +import org.apache.kafka.coordinator.group.api.assignor.SubscribedTopicDescriber; +import org.apache.kafka.coordinator.group.api.assignor.SubscriptionType; +import org.apache.kafka.coordinator.group.assignor.SimpleAssignor; +import org.apache.kafka.coordinator.group.modern.Assignment; +import org.apache.kafka.coordinator.group.modern.GroupSpecImpl; +import org.apache.kafka.coordinator.group.modern.MemberAssignmentImpl; +import org.apache.kafka.coordinator.group.modern.MemberSubscriptionAndAssignmentImpl; +import org.apache.kafka.coordinator.group.modern.SubscribedTopicDescriberImpl; +import org.apache.kafka.coordinator.group.modern.TopicIds; +import org.apache.kafka.coordinator.group.modern.share.ShareGroupMember; +import org.apache.kafka.image.MetadataImage; + +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Fork; +import org.openjdk.jmh.annotations.Level; +import org.openjdk.jmh.annotations.Measurement; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Param; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.annotations.State; +import org.openjdk.jmh.annotations.Threads; +import org.openjdk.jmh.annotations.Warmup; + +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.TimeUnit; + +import static org.apache.kafka.coordinator.group.api.assignor.SubscriptionType.HETEROGENEOUS; +import static org.apache.kafka.coordinator.group.api.assignor.SubscriptionType.HOMOGENEOUS; + +@State(Scope.Benchmark) +@Fork(value = 1) +@Warmup(iterations = 5) +@Measurement(iterations = 5) +@BenchmarkMode(Mode.AverageTime) +@OutputTimeUnit(TimeUnit.MILLISECONDS) +public class ShareGroupAssignorBenchmark { + + public enum AssignorType { + SIMPLE(new SimpleAssignor()); + + private final PartitionAssignor assignor; + + AssignorType(PartitionAssignor assignor) { + this.assignor = assignor; + } + + public PartitionAssignor assignor() { + return assignor; + } + } + + /** + * The assignment type is decided based on whether all the members are assigned partitions + * for the first time (full), or incrementally when a rebalance is triggered. + */ + public enum AssignmentType { + FULL, INCREMENTAL + } + + @Param({"10", "100", "1000"}) + private int memberCount; + + @Param({"1", "10", "100"}) + private int partitionCount; + + @Param({"10", "100"}) + private int topicCount; + + @Param({"HOMOGENEOUS", "HETEROGENEOUS"}) + private SubscriptionType subscriptionType; + + @Param({"SIMPLE"}) + private AssignorType assignorType; + + @Param({"FULL", "INCREMENTAL"}) + private AssignmentType assignmentType; + + private PartitionAssignor partitionAssignor; + + /** The number of homogeneous subgroups to create for the heterogeneous subscription case. */ + private static final int MAX_BUCKET_COUNT = 5; + + private GroupSpec groupSpec; + + private List<String> allTopicNames = Collections.emptyList(); Review Comment: It works because this variable is overwritten with a new list created by `AssignorBenchmarkUtils.createTopicNames`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
