AndrewJSchofield commented on code in PR #19900:
URL: https://github.com/apache/kafka/pull/19900#discussion_r2131694269
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -235,6 +238,13 @@ public class GroupCoordinatorConfig {
public static final int SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT =
15000;
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC =
"The maximum heartbeat interval for share group members.";
+ private static final ShareGroupPartitionAssignor
SHARE_GROUP_BUILTIN_ASSIGNOR = new SimpleAssignor();
+ public static final String SHARE_GROUP_ASSIGNORS_CONFIG =
"group.share.assignors";
+ public static final String SHARE_GROUP_ASSIGNORS_DOC = "The server-side
assignors as a list of full class names. " +
Review Comment:
I think you've done a slightly different thing here than it says in the KIP.
I think it's an improvement so I want to adjust the KIP too. The doc should say
`"The server-side assignors as a list of either names for built-in assignors or
full class names for custom assignors. The list must contain only a single
entry which is used by all groups. The supported built-in assignors are: " +
SHARE_GROUP_BUILTIN_ASSIGNOR.name() + "."`. I don't think there's any need to
include the sentence about future plans. That's more helpful as commentary in
the KIP. In this way, I think we have a futureproof behaviour and accurate
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
