edoardocomar commented on code in PR #19449:
URL: https://github.com/apache/kafka/pull/19449#discussion_r2132531954
##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverterConfig.java:
##########
@@ -61,6 +66,8 @@ public final class JsonConverterConfig extends
ConverterConfig {
orderInGroup++, Width.MEDIUM, SCHEMAS_ENABLE_DISPLAY);
CONFIG.define(SCHEMAS_CACHE_SIZE_CONFIG, Type.INT,
SCHEMAS_CACHE_SIZE_DEFAULT, Importance.HIGH, SCHEMAS_CACHE_SIZE_DOC, group,
orderInGroup++, Width.MEDIUM,
SCHEMAS_CACHE_SIZE_DISPLAY);
+ CONFIG.define(SCHEMA_CONTENT_CONFIG, Type.STRING,
SCHEMA_CONTENT_DEFAULT, Importance.HIGH, SCHEMA_CONTENT_DOC, group,
+ orderInGroup++, Width.MEDIUM, SCHEMA_CONTENT_DISPLAY);
Review Comment:
Could you have called the overloaded `define` which uses a Validator, for a
minimal check that the value is ok ?
As in the JSON converter for example you check not null and not 0 length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
