chia7712 commented on code in PR #19920: URL: https://github.com/apache/kafka/pull/19920#discussion_r2134723614
########## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java: ########## @@ -41,12 +45,19 @@ public class LoggersTest { private static final long INITIAL_TIME = 1696951712135L; private Loggers.Log4jLoggers loggers; private Time time; + Level originalRootLevel; @BeforeEach public void setup() { + originalRootLevel = LogManager.getRootLogger().getLevel(); time = new MockTime(0, INITIAL_TIME, 0); loggers = (Loggers.Log4jLoggers) Loggers.newInstance(time); } + + @AfterEach + public void teardown() { + Configurator.setAllLevels(LogManager.ROOT_LOGGER_NAME, originalRootLevel); Review Comment: This changes all 'child' loggers, right? If so, it is not a kind of restoring logger levels -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org