Yunyung commented on code in PR #19926:
URL: https://github.com/apache/kafka/pull/19926#discussion_r2135597580
##########
tests/docker/ducker-ak:
##########
@@ -431,15 +431,15 @@ attempting to start new ones."
exec 3>&-
for n in $(seq -f %02g 1 ${num_nodes}); do
local node="ducker${n}"
- docker exec --user=root "${node}" \
- bash -c "grep -v ${node}
/opt/kafka-dev/tests/docker/build/node_hosts >> /etc/hosts"
- [[ $? -ne 0 ]] && die "failed to append to the /etc/hosts file on
${node}"
# Filter out ipv4 addresses if ipv6
if [[ "${ipv6}" == "true" ]]; then
docker exec --user=root "${node}" \
bash -c "grep -v -E '([0-9]{1,3}\.){3}[0-9]{1,3}'
/opt/kafka-dev/tests/docker/build/node_hosts >> /etc/hosts"
- [[ $? -ne 0 ]] && die "failed to append to the /etc/hosts file on
${node}"
+ else
+ docker exec --user=root "${node}" \
+ bash -c "grep -v ${node}
/opt/kafka-dev/tests/docker/build/node_hosts >> /etc/hosts"
Review Comment:
I think we should do this.
@kevin-wu24 What do you think as the author of #19537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
