brandboat commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2138333620
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -1230,17 +1219,6 @@ public boolean paranoidFileChecks() {
return columnFamilyOptions.paranoidFileChecks();
}
- @Override
- public Options setMaxWriteBufferNumberToMaintain(final int
maxWriteBufferNumberToMaintain) {
-
columnFamilyOptions.setMaxWriteBufferNumberToMaintain(maxWriteBufferNumberToMaintain);
- return this;
- }
-
- @Override
- public int maxWriteBufferNumberToMaintain() {
- return columnFamilyOptions.maxWriteBufferNumberToMaintain();
- }
-
Review Comment:
Sorry for the late reply, you're right, this is indeed an issue in RocksDB.
I've filed a GitHub issue to track it:
https://github.com/facebook/rocksdb/issues/13680.
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -1230,17 +1219,6 @@ public boolean paranoidFileChecks() {
return columnFamilyOptions.paranoidFileChecks();
}
- @Override
- public Options setMaxWriteBufferNumberToMaintain(final int
maxWriteBufferNumberToMaintain) {
-
columnFamilyOptions.setMaxWriteBufferNumberToMaintain(maxWriteBufferNumberToMaintain);
- return this;
- }
-
- @Override
- public int maxWriteBufferNumberToMaintain() {
- return columnFamilyOptions.maxWriteBufferNumberToMaintain();
- }
-
Review Comment:
@cadonna, sorry for the late reply, you're right, this is indeed an issue in
RocksDB. I've filed a GitHub issue to track it:
https://github.com/facebook/rocksdb/issues/13680.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
