mimaison commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2963083096
Thanks for the PR! Overall I agree that we should ensure metrics don't collide so operators can rely on them to be accurate. On the other hand the cliend Id can be used for authorization and quotas so if we don't use the exact value provided by the user we may break existing systems. I'm leaning considering this as a bug and automatically injecting the task Id, as proposed in this PR. @gharris1727 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
