aliehsaeedii commented on code in PR #19646:
URL: https://github.com/apache/kafka/pull/19646#discussion_r2141088818
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsSpec.java:
##########
@@ -35,15 +35,15 @@ public class ListStreamsGroupOffsetsSpec {
/**
* Set the topic partitions whose offsets are to be listed for a streams
group.
*/
- ListStreamsGroupOffsetsSpec topicPartitions(Collection<TopicPartition>
topicPartitions) {
+ public ListStreamsGroupOffsetsSpec
topicPartitions(Collection<TopicPartition> topicPartitions) {
this.topicPartitions = topicPartitions;
return this;
}
/**
* Returns the topic partitions whose offsets are to be listed for a
streams group.
*/
- Collection<TopicPartition> topicPartitions() {
+ public Collection<TopicPartition> topicPartitions() {
return topicPartitions;
}
}
Review Comment:
They should've been defined public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
