gongxuanzhang commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r2144692245
########## clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java: ########## @@ -224,8 +225,7 @@ public void testDisallowedLoginModulesSystemProperty() throws Exception { "SOME-MECHANISM", Collections.emptyMap())); - //Remove default value for org.apache.kafka.disallowed.login.modules - System.setProperty(DISALLOWED_LOGIN_MODULES_CONFIG, ""); + // add allowed login modules Review Comment: The previous code was like this: ```java // Remove default value for org.apache.kafka.disallowed.login.modules System.setProperty(DISALLOWED_LOGIN_MODULES_CONFIG, ""); ``` After modifying the logic, the behavior of setting the DISALLOWED_LOGIN_MODULES_CONFIG property changed, so I updated the comment accordingly. However, since this PR has been open for a long time, someone removed that line of code during the process, and my comment was left behind. Sorry I didn’t review it carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org