k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2144967161
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ########## @@ -90,6 +92,8 @@ public InternalTopicManager(final Time time, final StreamsConfig streamsConfig) { this.time = time; this.adminClient = adminClient; + this.isManualInternalTopicConfig = streamsConfig.getString(StreamsConfig.INTERNAL_TOPIC_SETUP_CONFIG) + .equals(StreamsConfig.INTERNAL_TOPIC_SETUP_MANUAL); Review Comment: There may be an opportunity to use the InitParameters class here, but this approach seemed a bit cleaner to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org