chia7712 commented on code in PR #19922:
URL: https://github.com/apache/kafka/pull/19922#discussion_r2145771137
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5880,13 +5881,9 @@ class ReplicaManagerTest {
topicId = None
)
- val leaderAndIsrRequest = makeLeaderAndIsrRequest(
- topicId = topicId,
- topicPartition = tp,
- replicas = Seq(0, 1),
- leaderAndIsr = new LeaderAndIsr(0, List(0, 1).map(Int.box).asJava),
- )
- replicaManager.becomeLeaderOrFollower(0, leaderAndIsrRequest, (_, _) =>
())
+ val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true,
partitions = List(0, 1), List.empty, topic, topicIds(topic))
Review Comment:
It seems to me that it is fine, as the extra partition (tp-1) does not
impact the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
