mjsax commented on code in PR #19973:
URL: https://github.com/apache/kafka/pull/19973#discussion_r2150929147
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -169,10 +169,13 @@ public class TopicConfig {
"to trigger the unclean leader election immediately if needed.</p>";
public static final String MIN_IN_SYNC_REPLICAS_CONFIG =
"min.insync.replicas";
- public static final String MIN_IN_SYNC_REPLICAS_DOC = "When a producer
sets acks to \"all\" (or \"-1\"), " +
- "this configuration specifies the minimum number of replicas that must
acknowledge " +
- "a write for the write to be considered successful. If this minimum
cannot be met, " +
- "then the producer will raise an exception (either
<code>NotEnoughReplicas</code> or
<code>NotEnoughReplicasAfterAppend</code>).<br> " +
+ public static final String MIN_IN_SYNC_REPLICAS_DOC = "Specifies the
<i>minimum</i> number of in-sync replicas (including the leader) " +
+ "required for a write to succeed when a producer sets
<code>acks</code> to \"all\" (or \"-1\"). In the <code>acks=all</code> " +
+ "case, every in-sync replica must acknowledge a write for it to be
considered successful. E.g., if a topic has " +
+ "<code>replication.factor</code> of 3 and the ISR set includes all
three replicas, then all three replicas must acknowledge an " +
+ "<code>acks=all</code> write for it to succeed, even if
<code>min.insync.replicas</code> happens to be less than 3. " +
+ "If <code>acks=all</code> and the number of in-sync replicas is less
than <code>min.insync.replicas</code>, then the producer " +
Review Comment:
```suggestion
"If <code>acks=all</code> and the current ISR set contains fewer
than <code>min.insync.replicas</code> members, then the producer " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
