[
https://issues.apache.org/jira/browse/KAFKA-7917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767389#comment-16767389
]
John Roesler commented on KAFKA-7917:
-------------------------------------
Thanks for the comments, all.
The main motivation here is not a performance optimization (although there may
be some), but simplifying the code base.
I agree it will require some discussion, so I've picked up the ticket, and I'm
working on a WIP PR so we can have a concrete discussion about whether it
results in a simpler system or not.
As I've been working on it, I do think that [~guozhang] is right, it seems to
pave the way to needing that "root" store reference in init.
> Streams store cleanup: collapse layers
> --------------------------------------
>
> Key: KAFKA-7917
> URL: https://issues.apache.org/jira/browse/KAFKA-7917
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: John Roesler
> Assignee: John Roesler
> Priority: Major
>
> Following on KAFKA-7916, we can consider collapsing the "streams management
> layers" into one.
> Right now, we have:
> * metering (also handles moving from pojo world to bytes world)
> * change-logging
> * caching
> This is good compositional style, but we also have some runtime overhead of
> calling through all these layers, as well as some mental overhead of
> understanding how many and which layers we are going through.
> Also, there are dependencies between the caching and change-logging layers.
> I _think_ it would simplify the code if we collapsed these into one layer
> with boolean switches to turn on or off the different aspects. (rather than
> wrapping the store with the different layers or not depending on the same
> boolean conditions)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
