chia7712 commented on code in PR #19157:
URL: https://github.com/apache/kafka/pull/19157#discussion_r2160452806
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -196,7 +196,7 @@ private static void addVersionMappingParser(Subparsers
subparsers) {
);
versionMappingParser.addArgument("--release-version")
.help("The release version to use for the corresponding
feature mapping. The minimum is " +
- MetadataVersion.MINIMUM_VERSION + "; the default is "
+ MetadataVersion.LATEST_PRODUCTION)
+ MetadataVersion.MINIMUM_VERSION + "; the default is "
+ MetadataVersion.latestTesting().version())
Review Comment:
ditto
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -311,7 +311,7 @@ object StorageTool extends Logging {
formatParser.addArgument("--release-version", "-r")
.action(store())
.help(s"The release version to use for the initial feature settings. The
minimum is " +
- s"${MetadataVersion.MINIMUM_VERSION}; the default is
${MetadataVersion.LATEST_PRODUCTION}")
+ s"${MetadataVersion.MINIMUM_VERSION}; the default is
${MetadataVersion.latestTesting().version()}")
Review Comment:
Using `latestTesting` as default version is a bit weird to me. Could you
please share more details with me?
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -344,7 +344,7 @@ object StorageTool extends Logging {
versionMappingParser.addArgument("--release-version", "-r")
.action(store())
.help(s"The release version to use for the corresponding feature
mapping. The minimum is " +
- s"${MetadataVersion.MINIMUM_VERSION}; the default is
${MetadataVersion.LATEST_PRODUCTION}")
+ s"${MetadataVersion.MINIMUM_VERSION}; the default is
${MetadataVersion.latestTesting().version()}")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
