Yunyung commented on code in PR #20025:
URL: https://github.com/apache/kafka/pull/20025#discussion_r2163538855
##########
docs/security.html:
##########
@@ -556,8 +556,8 @@ <h3 class="anchor-heading"><a id="security_sasl"
class="anchor-link"></a><a href
<p>See <a
href="#security_sasl_kerberos_brokerconfig">GSSAPI (Kerberos)</a>,
<a href="#security_sasl_plain_brokerconfig">PLAIN</a>,
- <a href="#security_sasl_scram_brokerconfig">SCRAM</a>
or
- <a
href="#security_sasl_oauthbearer_brokerconfig">OAUTHBEARER</a> for example
broker configurations.</p></li>
+ <a href="#security_sasl_scram_brokerconfig">SCRAM</a>,
or
+ <a
href="#security_sasl_oauthbearer_non_production_brokerconfig">non-production</a>/<a
href="#security_sasl_oauthbearer_non_production_brokerconfig">production</a>
OAUTHBEARER for example broker configurations.</p></li>
Review Comment:
```suggestion
<a
href="#security_sasl_oauthbearer_non_production_brokerconfig">non-production</a>/<a
href="#security_sasl_oauthbearer_production_clientconfig">production</a>
OAUTHBEARER for example broker configurations.</p></li>
```
##########
docs/security.html:
##########
@@ -579,8 +579,8 @@ <h3 class="anchor-heading"><a id="security_sasl"
class="anchor-link"></a><a href
<p>See <a
href="#security_sasl_kerberos_clientconfig">GSSAPI (Kerberos)</a>,
<a
href="#security_sasl_plain_clientconfig">PLAIN</a>,
- <a
href="#security_sasl_scram_clientconfig">SCRAM</a> or
- <a
href="#security_sasl_oauthbearer_clientconfig">OAUTHBEARER</a> for example
configurations.</p></li>
+ <a
href="#security_sasl_scram_clientconfig">SCRAM</a>, or
+ <a
href="#security_sasl_oauthbearer_non_production_clientconfig">non-production</a>/<a
href="#security_sasl_oauthbearer_production_clientconfig">production</a>
OAUTHBEARER for example configurations.</p></li>
Review Comment:
Nit: Corresponding to "for example broker configurations" above.
```suggestion
<a
href="#security_sasl_oauthbearer_non_production_clientconfig">non-production</a>/<a
href="#security_sasl_oauthbearer_production_clientconfig">production</a>
OAUTHBEARER for example client configurations.</p></li>
```
##########
docs/security.html:
##########
@@ -927,8 +963,40 @@ <h3 class="anchor-heading"><a id="security_sasl"
class="anchor-link"></a><a href
sasl.enabled.mechanisms=OAUTHBEARER</code></pre></li>
</ol>
</li>
+ <li><h5 class="anchor-heading"><a
id="security_sasl_oauthbearer_production_brokerconfig"
class="anchor-link"></a><a
href="#security_sasl_oauthbearer_production_brokerconfig">Configuring
Production Kafka Brokers</a></h5>
+ <ol>
+ <li>Add a suitably modified JAAS file similar to the
one below to each Kafka broker's config directory, let's call it
kafka_server_jaas.conf for this example:
Review Comment:
Looks like there's no corresponding "\</li\>"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
