kevin-wu24 commented on code in PR #20021:
URL: https://github.com/apache/kafka/pull/20021#discussion_r2164212375
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -345,7 +346,18 @@ private void maybePublishMetadata(MetadataDelta delta,
MetadataImage image, Load
}
}
metrics.updateLastAppliedImageProvenance(image.provenance());
-
metrics.setCurrentMetadataVersion(image.features().metadataVersionOrThrow());
+ MetadataVersion metadataVersion =
image.features().metadataVersionOrThrow();
+ metrics.setCurrentMetadataVersion(metadataVersion);
+ metrics.setFinalizedFeatureLevel(
+ MetadataVersion.FEATURE_NAME,
+ metadataVersion.featureLevel()
+ );
+ for (var finalizedFeatureEntry :
image.features().finalizedVersions().entrySet()) {
+ metrics.setFinalizedFeatureLevel(
+ finalizedFeatureEntry.getKey(),
+ finalizedFeatureEntry.getValue()
+ );
+ }
Review Comment:
Yeah, for checks of current metadata version metric value, I will add a
check for the finalized feature level metric too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
