FrankYang0529 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-3003746529
From comment in `TopicBasedRemoteLogMetadataManager#ensureInitializedAndNotClosed` [0], it would like to stop the broker when there is an initialization error. However, the error doesn't really shutdown the broker. The `RemoteLogManager` uses thread pool to execute `RLMTask` and stores result in a map like `leaderCopyRLMTasks` [1], but it never check the result in it. The `RemoteLogManager` only cancel the task and log the exception [2]. IMO, we need to check `FatalExitError` and stop the broker. Or we don't use another thread to initialize resources in `TopicBasedRemoteLogMetadataManager` [3] and throw exception immediately if there is an error. cc @showuon @chia7712 [0] https://github.com/apache/kafka/blob/43871329264f311ec7b7bcd48d4be81549b03922/storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java#L562-L565 [1] https://github.com/apache/kafka/blob/43871329264f311ec7b7bcd48d4be81549b03922/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L1979-L1988 [2] https://github.com/apache/kafka/blob/43871329264f311ec7b7bcd48d4be81549b03922/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L2019-L2038 [3] https://github.com/apache/kafka/blob/43871329264f311ec7b7bcd48d4be81549b03922/storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java#L379-L383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
