mjsax commented on code in PR #20031:
URL: https://github.com/apache/kafka/pull/20031#discussion_r2164523024
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -559,6 +580,7 @@ public CompletableFuture<StreamsGroupHeartbeatResult>
streamsGroupHeartbeat(
}
try {
+
throwIfStreamsGroupHeartbeatRequestIsUsingUnsupportedFeatures(request);
Review Comment:
Nit: should we do this check after the "is valid" check?
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##########
@@ -584,7 +669,7 @@ public void testStreamsHeartbeatRequestValidation() throws
ExecutionException, I
.build(true);
AuthorizableRequestContext context =
mock(AuthorizableRequestContext.class);
- when(context.requestVersion()).thenReturn((int)
ApiKeys.SHARE_GROUP_HEARTBEAT.latestVersion());
+ when(context.requestVersion()).thenReturn((int)
ApiKeys.STREAMS_GROUP_HEARTBEAT.latestVersion());
Review Comment:
Uff... Nice catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
