[
https://issues.apache.org/jira/browse/KAFKA-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767905#comment-16767905
]
ASF GitHub Bot commented on KAFKA-7930:
---------------------------------------
muradm commented on pull request #6267: KAFKA-7930: topic is not internal if
explicitly listed in args
URL: https://github.com/apache/kafka/pull/6267
Simplest fix: topic is not internal if explicitly listed in --input-topics
or --intermediate-topics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StreamsResetter makes "changelog" topic naming assumptions
> ----------------------------------------------------------
>
> Key: KAFKA-7930
> URL: https://issues.apache.org/jira/browse/KAFKA-7930
> Project: Kafka
> Issue Type: Improvement
> Components: streams, tools
> Affects Versions: 2.1.0
> Reporter: Murad M
> Priority: Major
> Labels: features, needs-kip, patch-available, usability
>
> StreamsResetter deletes the topics considered internal. Currently it just
> checks the naming as per
> [code|https://github.com/apache/kafka/blob/1aae604861068bb7337d4972c9dcc0c0a99c374d/core/src/main/scala/kafka/tools/StreamsResetter.java#L660].
> If assumption is wrong (either topic prefix or suffix), tool becomes useless
> if aware even dangerous if not. Probably better either:
> * naming assumption should be optional and supply internal topics with
> argument (--internal-topics)
> * deletion could be optional (--no-delete-internal)
> * ignore topics which are included in list of --input-topics
> Faced this, when was trying to reset applications with GlobalKTable topics
> named as *-changelog. Such topics sometimes are not desirable for deletion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
