Yunyung commented on code in PR #20087:
URL: https://github.com/apache/kafka/pull/20087#discussion_r2180576936
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##########
@@ -545,12 +545,12 @@ public void checkCompressed(byte magic) {
RequestLocal.withThreadConfinedCaching().bufferSupplier()
);
- MemoryRecords validatedRecords = validatedResults.validatedRecords;
+ MemoryRecords validatedRecords = validatedResults.validatedRecords();
int i = 0;
for (RecordBatch batch : validatedRecords.batches()) {
assertTrue(batch.isValid());
- assertEquals(batch.timestampType(), TimestampType.CREATE_TIME);
+ assertEquals(TimestampType.CREATE_TIME, batch.timestampType());
maybeCheckBaseTimestamp(timestampSeq.get(0), batch);
assertEquals(batch.maxTimestamp(), batch.maxTimestamp());
Review Comment:
I also found this issue while reviewing this PR and have already filed a
MINOR to fix it before the comments. https://github.com/apache/kafka/pull/20093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
