karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2191447635
########## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ########## @@ -224,6 +224,9 @@ class LogRecoveryTest extends QuorumTestHarness { server1.startup() updateProducer() + waitUntilTrue(() => server2.replicaManager.onlinePartition(topicPartition).get.inSyncReplicaIds.size == 2, Review Comment: @junrao My previous fix was not addressing the specific failure point mentioned in the JIRA issue, and the waitUntilTrue I added was likely redundant for the reasons you mentioned. My apologies. I updated the commit with a fix for the actual issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org