ezhou413 commented on code in PR #20134:
URL: https://github.com/apache/kafka/pull/20134#discussion_r2195916008
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -579,7 +579,7 @@ public void testConstructorWithNotStringKey() {
ConfigException ce = assertThrows(
ConfigException.class,
() -> new KafkaProducer<>(props, new StringSerializer(), new
StringSerializer()));
- assertTrue(ce.getMessage().contains("not string key"), "Unexpected
exception message: " + ce.getMessage());
+ assertTrue(ce.getMessage().contains("must be a string"), "Unexpected
exception message: " + ce.getMessage());
Review Comment:
Yes the reason I changed this was because I omitted the property key and
value, but I thought it would be better to check for the error message instead
of the erroneous key and value. Happy to discard this change if the existing
message is preferred
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
