Yunyung commented on code in PR #20140:
URL: https://github.com/apache/kafka/pull/20140#discussion_r2197359132
##########
docs/implementation.html:
##########
@@ -59,11 +59,14 @@ <h4 class="anchor-heading"><a id="recordbatch"
class="anchor-link"></a><a href="
records: [Record]</code></pre>
<p> Note that when compression is enabled, the compressed record data is
serialized directly following the count of the number of records. </p>
+ <p>batchLength represents the number of bytes from the current position
(immediately after the batchLength field) to the end of the batch.
+ In other words, the total size of a record batch on disk is
batchLength + 12 bytes, which includes the 8-byte baseOffset and the 4-byte
batchLength field itself.</p>
Review Comment:
Please remove the extra tab.
##########
docs/implementation.html:
##########
@@ -59,11 +59,14 @@ <h4 class="anchor-heading"><a id="recordbatch"
class="anchor-link"></a><a href="
records: [Record]</code></pre>
<p> Note that when compression is enabled, the compressed record data is
serialized directly following the count of the number of records. </p>
+ <p>batchLength represents the number of bytes from the current position
(immediately after the batchLength field) to the end of the batch.
+ In other words, the total size of a record batch on disk is
batchLength + 12 bytes, which includes the 8-byte baseOffset and the 4-byte
batchLength field itself.</p>
+
<p>The CRC covers the data from the attributes to the end of the batch
(i.e. all the bytes that follow the CRC). It is located after the magic byte,
which
means that clients must parse the magic byte before deciding how to
interpret the bytes between the batch length and the magic byte. The partition
leader
epoch field is not included in the CRC computation to avoid the need to
recompute the CRC when this field is assigned for every batch that is received
by
the broker. The CRC-32C (Castagnoli) polynomial is used for the
computation.</p>
-
+
Review Comment:
Please remove the extra tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
