Yunyung commented on code in PR #20021:
URL: https://github.com/apache/kafka/pull/20021#discussion_r2202009032
##########
metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java:
##########
@@ -508,6 +513,61 @@ public void testLoadEmptyBatch() throws Exception {
faultHandler.maybeRethrowFirstException();
}
+ /**
+ * Test the kraft.version finalized level value is correct.
+ * @throws Exception
+ */
+ @Test
+ public void testKRaftVersionFinalizedLevelMetric() throws Exception {
Review Comment:
It would be great to also cover `handleLoadSnapshot` (before calling
`handleCommit`) and test whether KRaftVersion is set.
##########
metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java:
##########
@@ -508,6 +513,61 @@ public void testLoadEmptyBatch() throws Exception {
faultHandler.maybeRethrowFirstException();
}
+ /**
+ * Test the kraft.version finalized level value is correct.
+ * @throws Exception
+ */
+ @Test
+ public void testKRaftVersionFinalizedLevelMetric() throws Exception {
+ MockFaultHandler faultHandler = new
MockFaultHandler("testLoadEmptyBatch");
Review Comment:
```suggestion
MockFaultHandler faultHandler = new
MockFaultHandler("testKRaftVersionFinalizedLevelMetric");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
