chia7712 commented on code in PR #20144:
URL: https://github.com/apache/kafka/pull/20144#discussion_r2202770861
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -717,7 +718,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (Throwable e) {
+ } catch (IOException | NoClassDefFoundError e) {
log.debug("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
@k-raina catching the `Throwable` is not a major issue, so there is no hurry
to include it in the 4.1.0 release. Perhaps you could address @apoorvmittal10
comment in this PR, and then we could backport it to 4.1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
