junrao commented on code in PR #20137:
URL: https://github.com/apache/kafka/pull/20137#discussion_r2205560889
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -83,7 +83,9 @@ public void testFromVersionString() {
assertEquals(IBP_4_0_IV2,
MetadataVersion.fromVersionString("4.0-IV2"));
assertEquals(IBP_4_0_IV3,
MetadataVersion.fromVersionString("4.0-IV3"));
+ // 4.1-IV1 is the latest production version in the 4.1 line
assertEquals(IBP_4_1_IV0,
MetadataVersion.fromVersionString("4.1-IV0"));
+ assertEquals(IBP_4_1_IV1,
MetadataVersion.fromVersionString("4.1-IV1"));
Review Comment:
Could we add the test for string "4.1" and "4.0"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
