chia7712 commented on code in PR #20083: URL: https://github.com/apache/kafka/pull/20083#discussion_r2207644130
########## storage/src/main/java/org/apache/kafka/storage/internals/log/CommittedPartitionState.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.metadata.LeaderRecoveryState; + +import java.util.Collections; +import java.util.Set; + +public record CommittedPartitionState(Set<Integer> isr, LeaderRecoveryState leaderRecoveryState) implements PartitionState { Review Comment: Could you please initialize isr as immutable? for example: ```java public CommittedPartitionState { isr = Collections.unmodifiableSet(isr); } ``` ########## storage/src/main/java/org/apache/kafka/storage/internals/log/PendingPartitionChange.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.metadata.LeaderAndIsr; + +public interface PendingPartitionChange extends PartitionState { + CommittedPartitionState lastCommittedState(); + LeaderAndIsr sentLeaderAndIsr(); + void notifyListener(AlterPartitionListener alterPartitionListener); Review Comment: `notifyListener` is used for a single purpose. Perhaps we can decouple `AlterPartitionListener` from `PendingPartitionChange`. for example: ```scala proposedIsrState match { case _: PendingExpandIsr => alterPartitionListener.markIsrExpand() case _: PendingShrinkIsr => alterPartitionListener.markIsrShrink() } ``` ########## storage/src/main/java/org/apache/kafka/storage/internals/log/PartitionState.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.metadata.LeaderRecoveryState; + +import java.util.Set; + +public interface PartitionState { + /** + * Includes only the in-sync replicas which have been committed to ZK. + */ + Set<Integer> isr(); + + /** + * This set may include un-committed ISR members following an expansion. This "effective" ISR is used for advancing + * the high watermark as well as determining which replicas are required for acks=all produce requests. + * + * Only applicable as of IBP 2.7-IV2, for older versions this will return the committed ISR Review Comment: this comment is out-of-date, shouldn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
