sebastienviale commented on code in PR #17942:
URL: https://github.com/apache/kafka/pull/17942#discussion_r2210180993


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java:
##########
@@ -357,7 +357,7 @@ public void 
shouldStopProcessingWhenProcessingExceptionHandlerReturnsNull() {
             final StreamsException e = assertThrows(StreamsException.class, () 
-> inputTopic.pipeInput(eventError.key, eventError.value, Instant.EPOCH));
             assertEquals("Fatal user code error in processing error callback", 
e.getMessage());
             assertInstanceOf(NullPointerException.class, e.getCause());
-            assertEquals("Invalid ProductionExceptionHandler response.", 
e.getCause().getMessage());
+            assertEquals("Invalid ProcessingExceptionResponse response.", 
e.getCause().getMessage());

Review Comment:
   @lucasbru do I have to change the message to "Invalid 
ProductionExceptionHandler response." form here too ?
   
   
https://github.com/Dabz/kafka/blob/32289d2d391f4d43cd05e7ee399e614f1fe65152/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java#L228
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to