frankvicky commented on code in PR #20165:
URL: https://github.com/apache/kafka/pull/20165#discussion_r2210408211
##########
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##########
@@ -301,7 +301,7 @@ public void checkArgs() {
CommandLineUtils.checkInvalidArgs(parser, options, createOpt,
Set.of(hmacOpt, renewTimePeriodOpt, expiryTimePeriodOpt));
CommandLineUtils.checkInvalidArgs(parser, options, renewOpt,
Set.of(renewPrincipalsOpt, maxLifeTimeOpt, expiryTimePeriodOpt,
ownerPrincipalsOpt));
CommandLineUtils.checkInvalidArgs(parser, options, expiryOpt,
Set.of(renewOpt, maxLifeTimeOpt, renewTimePeriodOpt, ownerPrincipalsOpt));
- CommandLineUtils.checkInvalidArgs(parser, options, describeOpt,
Set.of(renewTimePeriodOpt, maxLifeTimeOpt, hmacOpt, renewTimePeriodOpt,
expiryTimePeriodOpt));
+ CommandLineUtils.checkInvalidArgs(parser, options, describeOpt,
Set.of(renewTimePeriodOpt, maxLifeTimeOpt, hmacOpt, expiryTimePeriodOpt));
Review Comment:
It seems that this will cause the e2e error.
The duplicate arguments will cause `Set.of` throws
`IllegalArgumentException`.
We could open another patch to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
