frankvicky commented on code in PR #20200:
URL: https://github.com/apache/kafka/pull/20200#discussion_r2217212131
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -1230,6 +1230,40 @@ public void
testEligibleLeaderReplicas_ElectLastKnownLeaderShouldFail() {
builder.setTargetIsr(List.of());
+ // No change to the partition.
+ assertEquals(Optional.empty(), builder.build());
+ }
+
+ @Test
+ public void testEligibleLeaderReplicas_NotEligiblableLastKnownLeader() {
Review Comment:
```suggestion
public void testEligibleLeaderReplicas_NotEligibleLastKnownLeader() {
```
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -1230,6 +1230,40 @@ public void
testEligibleLeaderReplicas_ElectLastKnownLeaderShouldFail() {
builder.setTargetIsr(List.of());
+ // No change to the partition.
+ assertEquals(Optional.empty(), builder.build());
+ }
+
+ @Test
+ public void testEligibleLeaderReplicas_NotEligiblableLastKnownLeader() {
+ short version = 2;
+ PartitionRegistration partition = new PartitionRegistration.Builder()
+ .setReplicas(new int[] {1, 2, 3, 4})
+ .setDirectories(new Uuid[]{
+ Uuid.fromString("zANDdMukTEqefOvHpmniMg"),
+ Uuid.fromString("Ui2Eq8rbRiuW7m7uiPTRyg"),
+ Uuid.fromString("MhgJOZrrTsKNcGM0XKK4aA"),
+ Uuid.fromString("Y25PaCAmRfyGIKxAThhBAw")
+ })
+ .setIsr(new int[] {})
+ .setElr(new int[] {})
+ .setLastKnownElr(new int[] {1})
+ .setLeader(-1)
+ .setLeaderRecoveryState(LeaderRecoveryState.RECOVERED)
+ .setLeaderEpoch(100)
+ .setPartitionEpoch(200)
+ .build();
+ Uuid topicId = Uuid.fromString("FbrrdcfiR-KC2CPSTHaJrg");
+
+ PartitionChangeBuilder builder = new PartitionChangeBuilder(partition,
topicId, 0, r -> false,
+ metadataVersionForPartitionChangeRecordVersion(version), 3)
+ .setElection(Election.PREFERRED)
Review Comment:
Should we add a scenario for `Election.UNCLEAN`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
