chia7712 commented on code in PR #20134:
URL: https://github.com/apache/kafka/pull/20134#discussion_r2218179982
##########
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java:
##########
@@ -896,12 +896,134 @@ public void testPropsToMap() {
assertValue(Collections.emptyMap());
}
+ @Test
+ public void testPropsToMapNonStringKey() {
+ ConfigException ce = assertThrows(ConfigException.class, () -> {
+ Properties props = new Properties();
+ props.put(1, "value");
+ Utils.propsToMap(props);
+ });
+ assertTrue(ce.getMessage().contains("One or more keys is not a
string."));
+
+ ce = assertThrows(ConfigException.class, () -> {
+ Properties props = new Properties();
+ props.put(true, "value");
+ props.put('a', "value");
+ Utils.propsToMap(props);
+ });
+ assertTrue(ce.getMessage().contains("One or more keys is not a
string."));
+ }
+
+ @Test
+ public void testPropsToMapWithDefaults() {
+ Properties defaultProperties = new Properties();
+ defaultProperties.setProperty("DefaultKey1", "DefaultValue1");
+ defaultProperties.setProperty("DefaultKey2", "DefaultValue2");
+
+ Properties actualProperties = new Properties(defaultProperties);
+ actualProperties.setProperty("ActualKey1", "ActualValue1");
+ actualProperties.setProperty("ActualKey2", "ActualValue2");
+
+ final Map<String, Object> mapProperties =
Utils.propsToMap(actualProperties);
+
+ Map<String, Object> expectedMap = new HashMap<>();
+ expectedMap.put("DefaultKey1", "DefaultValue1");
+ expectedMap.put("DefaultKey2", "DefaultValue2");
+ expectedMap.put("ActualKey1", "ActualValue1");
+ expectedMap.put("ActualKey2", "ActualValue2");
+
+ assertEquals(expectedMap, mapProperties);
+ }
+
+ @Test
+ public void testPropsToMapWithDefaultsAndSameKey() {
+ Properties defaultProperties = new Properties();
+ defaultProperties.setProperty("DefaultKey1", "DefaultValue1");
+ defaultProperties.setProperty("DefaultKey2", "DefaultValue2");
+
+ Properties actualProperties = new Properties(defaultProperties);
+ actualProperties.setProperty("DefaultKey1", "ActualValue1");
+ actualProperties.setProperty("ActualKey2", "ActualValue2");
+
+ final Map<String, Object> mapProperties =
Utils.propsToMap(actualProperties);
+
+ Map<String, Object> expectedMap = new HashMap<>();
+ expectedMap.put("DefaultKey1", "ActualValue1");
+ expectedMap.put("DefaultKey2", "DefaultValue2");
+ expectedMap.put("ActualKey2", "ActualValue2");
+
+ assertEquals(expectedMap, mapProperties);
+ }
+
private static void assertValue(Object value) {
Properties props = new Properties();
props.put("key", value);
assertEquals(Utils.propsToMap(props).get("key"), value);
}
+ @Test
+ public void testCastToStringObjectMap() {
+ Map<Object, Object> map = new HashMap<>();
+ map.put("key1", "value1");
+ map.put("key2", 1);
+
+ Map<String, Object> expectedMap = new HashMap<>();
+ expectedMap.put("key1", "value1");
+ expectedMap.put("key2", 1);
+
+ assertEquals(map, expectedMap);
+ }
+
+ @Test
+ public void testCastToStringObjectMapNonStringKey() {
+ ConfigException ce = assertThrows(ConfigException.class, () -> {
+ Map<Object, Object> map = new HashMap<>();
+ map.put(1, "value");
+ Utils.castToStringObjectMap(map);
+ });
+ assertTrue(ce.getMessage().contains("Key must be a string"));
+
+ ce = assertThrows(ConfigException.class, () -> {
+ Map<Object, Object> map = new HashMap<>();
+ map.put(true, "value");
+ map.put('a', "value");
+ Utils.castToStringObjectMap(map);
+ });
+ assertTrue(ce.getMessage().contains("Key must be a string"));
+ }
+
+ @Test
+ public void testCastToStringObjectMapPropertiesAsInput() {
Review Comment:
Could you please add unit test for defaults behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
