AndrewJSchofield commented on code in PR #20224:
URL: https://github.com/apache/kafka/pull/20224#discussion_r2224769084
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -329,7 +329,7 @@ private void
logInternalConverterRemovalWarnings(Map<String, String> props) {
+ "and specifying them will have no effect. "
+ "Instead, an instance of the JsonConverter with
schemas.enable "
+ "set to false will be used. For more
information, please visit "
- + "https://kafka.apache.org/documentation/#upgrade
and consult the upgrade notes"
+ + "https://kafka.apache.org/documentation/#upgrade
and consult the upgrade notes "
Review Comment:
I really question whether this is the best option now since 3.0 is so long
ago. I wonder whether "These properties have been removed and an instance of
the JsonConverter with schemas.enable set to false will be used instead.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
