AndrewJSchofield commented on code in PR #20238:
URL: https://github.com/apache/kafka/pull/20238#discussion_r2228115554
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -467,7 +471,7 @@ protected void handleFindCoordinatorResponse(ClientResponse
response) {
default:
log.error("Unable to find coordinator for {} using key
{}.", name(), partitionKey());
- findCoordinatorErrorResponse(error, null);
+ findCoordinatorErrorResponse(error, new
Exception(errMessage));
Review Comment:
Why did you choose to pass the error message for this case but not the other
RPCs? I would have expected consistent failing in all cases.
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -437,6 +437,10 @@ protected void
handleFindCoordinatorResponse(ClientResponse response) {
FindCoordinatorResponseData.Coordinator coordinatorData =
coordinators.get(0);
Errors error = Errors.forCode(coordinatorData.errorCode());
+ String errMessage = coordinatorData.errorMessage();
Review Comment:
nit: `errorMessage` has been used in the other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
