Yunyung commented on PR #20239: URL: https://github.com/apache/kafka/pull/20239#issuecomment-3116727404
> Hi @mjsax , just found that without the default implementation the code can't pass the test `org.gradle.api.plugins.quality.internal.CheckstyleAction`, so I add it back. Hi, actually it's not needed, i think Checkstyle just needs the variables to be declared final: https://github.com/apache/kafka/pull/20239/commits/dae43e896251fca1834886fd734bc4381d5be21d You can test it locally with `./gradlew checkstyleMain checkstyleTest spotlessCheck` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
