Mirai1129 opened a new pull request, #20243:
URL: https://github.com/apache/kafka/pull/20243

   the constructor is error-prone when migrating code, since metrics could get 
unintentionally changed. We should remove the constructor and use constant 
strings instead to avoid issues like 
[KAFKA-17876](https://issues.apache.org/jira/browse/KAFKA-17876), 
[KAFKA-19150](https://issues.apache.org/jira/browse/KAFKA-19150), and others


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to