lucasbru commented on code in PR #20251:
URL: https://github.com/apache/kafka/pull/20251#discussion_r2239778458


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -646,6 +646,13 @@ public class StreamsConfig extends AbstractConfig {
         + " Set to -1 to disable idling entirely and process any locally 
available data,"
         + " even though doing so may produce out-of-order processing.";
 
+    /** {@code missing.source.topic.timeout.ms} */

Review Comment:
   This requires a KIP. We can just use max.poll.interval.ms.



##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -216,6 +216,8 @@ public interface UserTaskAssignmentListener {
     private AtomicLong nextScheduledRebalanceMs;
     private Queue<StreamsException> nonFatalExceptionsToHandle;
     private Time time;
+    private long missingSourceTopicTimeoutMs;

Review Comment:
   The idea was to implement this for the new protocol. Check 
`StreamThread.handleStreamsRebalanceData` and see if you can add the logic 
there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to