m1a2st commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2241843578
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##########
@@ -153,6 +155,29 @@ public void
testResetOffsetsNotExistingGroup(ClusterInstance cluster) throws Exc
}
}
+ @ClusterTest(
+ brokers = 2,
+ serverProperties = {
+ @ClusterConfigProperty(key =
OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "2"),
+ @ClusterConfigProperty(key =
TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG, value = "1")
Review Comment:
The
[min.insync.replicas](https://kafka.apache.org/documentation/#brokerconfigs_min.insync.replicas)
default value is 1, so we don't need to configure it explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
