jsancio commented on code in PR #19589:
URL: https://github.com/apache/kafka/pull/19589#discussion_r2242952821
##########
raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java:
##########
@@ -181,17 +185,21 @@ public void pollOnce() {
static AbstractRequest.Builder<? extends AbstractRequest>
buildRequest(ApiMessage requestData) {
if (requestData instanceof VoteRequestData)
return new VoteRequest.Builder((VoteRequestData) requestData);
- if (requestData instanceof BeginQuorumEpochRequestData)
+ else if (requestData instanceof BeginQuorumEpochRequestData)
return new
BeginQuorumEpochRequest.Builder((BeginQuorumEpochRequestData) requestData);
- if (requestData instanceof EndQuorumEpochRequestData)
+ else if (requestData instanceof EndQuorumEpochRequestData)
return new
EndQuorumEpochRequest.Builder((EndQuorumEpochRequestData) requestData);
- if (requestData instanceof FetchRequestData)
+ else if (requestData instanceof FetchRequestData)
return new FetchRequest.SimpleBuilder((FetchRequestData)
requestData);
- if (requestData instanceof FetchSnapshotRequestData)
+ else if (requestData instanceof FetchSnapshotRequestData)
return new FetchSnapshotRequest.Builder((FetchSnapshotRequestData)
requestData);
- if (requestData instanceof UpdateRaftVoterRequestData)
+ else if (requestData instanceof UpdateRaftVoterRequestData)
return new
UpdateRaftVoterRequest.Builder((UpdateRaftVoterRequestData) requestData);
- if (requestData instanceof ApiVersionsRequestData)
+ else if (requestData instanceof AddRaftVoterRequestData)
+ return new AddRaftVoterRequest.Builder((AddRaftVoterRequestData)
requestData);
+ else if (requestData instanceof RemoveRaftVoterRequestData)
+ return new
RemoveRaftVoterRequest.Builder((RemoveRaftVoterRequestData) requestData);
+ else if (requestData instanceof ApiVersionsRequestData)
Review Comment:
I say we add an `else` clause to make it consistent with the rest of the
code:
```java
else {
throw new IllegalArgumentException("Unexpected type for requestData: " +
requestData);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
