lucasbru commented on PR #20262: URL: https://github.com/apache/kafka/pull/20262#issuecomment-3136785655
> Good catch! > > We have a whole machinery in `StreamsMetricsImpl` to create and name sensors, also for thread-level sensors. Maybe you can re-use some of those to have a consistent sensor naming. See > > https://github.com/apache/kafka/blob/fb054b590e774374f4e9ce7ad5e69b3f98ffbd77/streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java#L267 I saw this, but I was hesitant to depend on 1000 LOC machinery just to define 5 constants strings, but I guess it's the "Streams" way to do this. So in the end, I'm fine with this solution as well. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
