k-apol commented on code in PR #20063:
URL: https://github.com/apache/kafka/pull/20063#discussion_r2247678846


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -113,7 +113,7 @@ public InternalTopicManager(final Time time,
         }
     }
 
-    static class ValidationResult {
+    public static class ValidationResult {

Review Comment:
   I did this because I will need to [access it from KakfaStreams.java when I 
implement the new 
`doInit()`](https://github.com/apache/kafka/pull/19913/files#diff-ab27af136b0c45ed402ec44368a91380b018bf06f1a9722324fe6be8d5220f7dR406)
  method. 
   
   Alternatively, I could make it `protected static class ...` instead to make 
it less available. But, my current understanding is that if I want to access 
this guy from KafkaStreams.java, I can't just leave it as it, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to