chia7712 commented on code in PR #20337:
URL: https://github.com/apache/kafka/pull/20337#discussion_r2267206403
##########
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##########
@@ -213,7 +213,6 @@ public LocalReplicaChanges localChanges(int brokerId) {
PartitionRegistration prevPartition =
image.partitions().get(entry.getKey());
if (
Review Comment:
could you please consider rewriting the condition in a single line?
```java
if (prevPartition == null || prevPartition.directory(brokerId) !=
entry.getValue().directory(brokerId)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
