sjhajharia commented on code in PR #20156:
URL: https://github.com/apache/kafka/pull/20156#discussion_r2268603857
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java:
##########
@@ -577,7 +576,7 @@ public Class<? extends Task> taskClass() {
@Override
public List<Map<String, String>> taskConfigs(int maxTasks) {
block.maybeBlockOn(CONNECTOR_TASK_CONFIGS);
- return Collections.singletonList(Collections.emptyMap());
+ return List.of(Map.of());
Review Comment:
Are you referencing to get rid of `.collect(Collectors.toList())` in favour
of `.toList()`, if so, then that is not possible here as we are using HashMap
while the return type needs to be Map.
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java:
##########
@@ -577,7 +576,7 @@ public Class<? extends Task> taskClass() {
@Override
public List<Map<String, String>> taskConfigs(int maxTasks) {
block.maybeBlockOn(CONNECTOR_TASK_CONFIGS);
- return Collections.singletonList(Collections.emptyMap());
+ return List.of(Map.of());
Review Comment:
Are you referencing to get rid of `.collect(Collectors.toList())` in favour
of `.toList()`? if so, then that is not possible here as we are using HashMap
while the return type needs to be Map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
