jolshan commented on code in PR #20303:
URL: https://github.com/apache/kafka/pull/20303#discussion_r2270473632
##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -180,14 +180,16 @@ public void testIgnoreFormatted() throws Exception {
try (TestEnv testEnv = new TestEnv(1)) {
FormatterContext formatter1 = testEnv.newFormatter();
formatter1.formatter.run();
- assertEquals("Formatting metadata directory " +
testEnv.directory(0) +
- " with metadata.version " + MetadataVersion.latestProduction()
+ ".",
- formatter1.output().trim());
+ assertEquals("Bootstrap metadata: " +
formatter1.formatter.bootstrapMetadata() +
+ "\nFormatting metadata directory " + testEnv.directory(0) +
+ " with metadata.version " +
MetadataVersion.latestProduction() + ".",
+ formatter1.output().trim());
FormatterContext formatter2 = testEnv.newFormatter();
formatter2.formatter.setIgnoreFormatted(true);
formatter2.formatter.run();
- assertEquals("All of the log directories are already formatted.",
+ assertEquals("Bootstrap metadata: " +
formatter2.formatter.bootstrapMetadata() +
Review Comment:
Sorry my comment wasn't quite clear. I meant that would it be confusing to
the end user to see this printout if this isn't the current settings? In other
words, should we not print out the values in formatter if we don't end up
formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
