mjsax commented on code in PR #20347:
URL: https://github.com/apache/kafka/pull/20347#discussion_r2274993836
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -244,8 +258,13 @@ public void shouldRestoreNullRecord() throws Exception {
}
@ParameterizedTest
- @ValueSource(booleans = {true, false})
- public void shouldRestoreStateFromSourceTopicForReadOnlyStore(final
boolean stateUpdaterEnabled) throws Exception {
+ @CsvSource({
Review Comment:
We should do the same for all other test case, like
`shouldRestoreNullRecord` above. There is 8 test methods I did not miscount,
but you enable the new protocol only for two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
