mjsax commented on code in PR #20325:
URL: https://github.com/apache/kafka/pull/20325#discussion_r2275137991
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -64,6 +77,9 @@ class DefaultAutoTopicCreationManager(
) extends AutoTopicCreationManager with Logging {
private val inflightTopics = Collections.newSetFromMap(new
ConcurrentHashMap[String, java.lang.Boolean]())
+ private val topicCreationErrorCache = new ConcurrentHashMap[String,
CachedTopicCreationError]()
+ private val errorCacheTtlMs = config.requestTimeoutMs.toLong * 3 // 3x
request timeout
Review Comment:
> I think the topic is globally used, so if it's missing then it's missing
for all groups
My understanding was, that `AutoTopicCreationManager.scala` is used to
create internal topics for KS apps. Or course, the manager is used for all
groups, but it does create topics which are individual to a specific group.
So if there is two KS applications, and there is an issue creating a topic
for application A, we need to ensure to report this error back to application A
(and only to application A, but not also to application B).
And we would also buffer error messages for application A with the
application A specific `session.timeout.ms` (and not use `session.timeout.ms`
of application B, for application A errors)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
